You should never upgrade units unless you take everything that increases training speed, or you will lose a lot of time and speedups. Feel free to upgrade units if you just unlocked tier 5 and need a specific type of tier 5 unit that you will use with your best heroes so you can optimize your daily free healing.